FIX: Display 'No SBOM' in multi-arch images in HarborUI #21459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the `hasChild` method to check for the presence of `child_digest` in the `references` array. * This ensures that SBOMs are correctly displayed for multi-arch images, where child artifacts may contain their own SBOMs. * Previously, No SBOM label was displayed for multi-arch images. Signed-off-by: bupd <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21459 +/- ##
==========================================
+ Coverage 45.36% 46.25% +0.88%
==========================================
Files 244 247 +3
Lines 13333 13886 +553
Branches 2719 2876 +157
==========================================
+ Hits 6049 6423 +374
- Misses 6983 7124 +141
- Partials 301 339 +38
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hi @bupd , |
|
@MinerYang Updated the PR description with screenshot. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Changes made
hasChildmethod to check for the presence of child images. aka. detecting multi-arch images.Screenshots
Before
After (SBOM column is empty for multi-arch images)
Issue being fixed
Fixes #21424
Please indicate you've done the following: